Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2183 +/- ##
==========================================
+ Coverage 95.10% 95.13% +0.03%
==========================================
Files 29 29
Lines 2943 2941 -2
Branches 443 441 -2
==========================================
- Hits 2799 2798 -1
- Misses 86 87 +1
+ Partials 58 56 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This change fixes a mismatch between the NWB schema and the PyNWB
Unitsmapper for waveform metadata.The schema defines
sampling_rateandunitattributes onwaveform_mean,waveform_sd, andwaveforms, but PyNWB only propagatedUnits.waveform_rateandUnits.waveform_unittowaveform_meanandwaveform_sd. As a result, aUnitstable containing onlywaveformswould lose waveform sampling metadata on write, andwaveform_ratewould not round-trip on read.Fix #2182.
What changed
VectorDatamapper soUnits.waveform_rateandUnits.waveform_unitare also written to thewaveformscolumn attributes.UnitsMaplogic so it also considerswaveformswhen reconstructing waveform metadata.Unitstable with onlywaveformsand verifies both the in-memory metadata and the on-disk attributes.How to test the behavior?
Checklist
ruff check . && codespellfrom the source directory.Prepared with Codex.