-
Notifications
You must be signed in to change notification settings - Fork 93
Add time duration methods #2146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add time duration methods #2146
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2146 +/- ##
==========================================
+ Coverage 95.23% 95.28% +0.04%
==========================================
Files 29 29
Lines 2876 2904 +28
Branches 740 748 +8
==========================================
+ Hits 2739 2767 +28
Misses 83 83
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This looks great to me, thanks for working on this, @h-mayorquin ! I'd be interested in @oruebel 's thoughts as well |
This is looks overall good to me. I added a few small suggestions, but overall this seems fine to me. I'll let @stephprince do final review and approval. |
|
Looks good to me. Thanks @h-mayorquin ! |
|
this looks great. Once this is released, let's modify NWB inspector to use these methods. Let's also port the Units table timing logic that is currently in the NWB Inspector library into PyNWB and do the same there. |
Motivation
Previously discussed in slack. One difficulty that users have when building an NWBFile is to understand the overall time organization of the data. There is a push for providing better reporting of this and these methods would be useful in this context.
Checklist
ruff check . && codespellfrom the source directory.