Open
Conversation
HDMF now validates DynamicTableRegion data bounds at construction time, raising IndexError for out-of-range values. Construct without table first, then set table afterwards to bypass validation and test our check function. Fixes #695 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #696 +/- ##
==========================================
+ Coverage 80.01% 82.55% +2.54%
==========================================
Files 48 48
Lines 1886 1886
==========================================
+ Hits 1509 1557 +48
+ Misses 377 329 -48 🚀 New features to boost your workflow:
|
Contributor
|
This is a duplicate of #681 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DynamicTableRegiondata bounds at construction time, raisingIndexErrorfor out-of-range valuesDynamicTableRegionwithout thetableargument first, then assigntableafterwards to bypass validation while still testing our check functionFixes #695
Test plan
test_check_dynamic_table_region_data_validity_lt_zeropassestest_check_dynamic_table_region_data_validity_gt_lenpassestest_tables.pypass🤖 Generated with Claude Code