Skip to content

Fix DynamicTableRegion tests for latest HDMF#696

Open
bendichter wants to merge 1 commit intodevfrom
fix-hdmf-dtr-validation-tests
Open

Fix DynamicTableRegion tests for latest HDMF#696
bendichter wants to merge 1 commit intodevfrom
fix-hdmf-dtr-validation-tests

Conversation

@bendichter
Copy link
Copy Markdown
Contributor

Summary

  • HDMF now validates DynamicTableRegion data bounds at construction time, raising IndexError for out-of-range values
  • Updated two tests to construct DynamicTableRegion without the table argument first, then assign table afterwards to bypass validation while still testing our check function

Fixes #695

Test plan

  • test_check_dynamic_table_region_data_validity_lt_zero passes
  • test_check_dynamic_table_region_data_validity_gt_len passes
  • All 47 tests in test_tables.py pass

🤖 Generated with Claude Code

HDMF now validates DynamicTableRegion data bounds at construction time,
raising IndexError for out-of-range values. Construct without table first,
then set table afterwards to bypass validation and test our check function.

Fixes #695

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.55%. Comparing base (56c728c) to head (6cd3deb).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #696      +/-   ##
==========================================
+ Coverage   80.01%   82.55%   +2.54%     
==========================================
  Files          48       48              
  Lines        1886     1886              
==========================================
+ Hits         1509     1557      +48     
+ Misses        377      329      -48     

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rly
Copy link
Copy Markdown
Contributor

rly commented Apr 7, 2026

This is a duplicate of #681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: tests failing with latest HDMF

3 participants