[Zarr-Support] Introduce LazyArray abstraction for HDF5-backed DataStub#800
Open
ehennestad wants to merge 15 commits intorefactor-hdf5-backend-readerfrom
Open
[Zarr-Support] Introduce LazyArray abstraction for HDF5-backed DataStub#800ehennestad wants to merge 15 commits intorefactor-hdf5-backend-readerfrom
ehennestad wants to merge 15 commits intorefactor-hdf5-backend-readerfrom
Conversation
…-add-lazy-array-generalization
…-add-lazy-array-generalization
…azy-array-generalization
…azy-array-generalization
Allow creating instance without inputs
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## refactor-hdf5-backend-reader #800 +/- ##
================================================================
- Coverage 95.51% 95.42% -0.09%
================================================================
Files 195 199 +4
Lines 7151 7208 +57
================================================================
+ Hits 6830 6878 +48
- Misses 321 330 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Create a
LazyArraybase type and aHDF5LazyArraybackend for theDataStubclass. This moves all h5 specific code out of theDataStuband prepares for adding support to read Zarr files .What Changed
io.backend.base.LazyArrayio.backend.hdf5.HDF5LazyArraytypes.untyped.DataStubto delegate metadata lookup and lazy loads through a backend lazy arrayio.backend.hdf5.HDF5Readerto wrap non-scalar non-empty datasets inDataStubbacked byHDF5LazyArrayHDF5LazyArraycoverage