Skip to content

Codex/review 1#4

Merged
Neo23x0 merged 2 commits intomainfrom
codex/review-1
Feb 8, 2026
Merged

Codex/review 1#4
Neo23x0 merged 2 commits intomainfrom
codex/review-1

Conversation

@Neo23x0
Copy link
Owner

@Neo23x0 Neo23x0 commented Feb 8, 2026

Summary

  • escape rule meta values (description, author, reference) in rule generation to prevent malformed YARA when inputs contain quotes/backslashes/newlines
  • harden scoring rule import to avoid duplicate non-builtin entries by updating existing matching rules on re-import
  • emit a warning when a regex scoring rule cannot be compiled during engine reload
  • avoid panic risk in yargen-util merge by handling inspect failures after merge
  • add targeted tests for metadata escaping, import dedupe/update behavior, and invalid-regex warning behavior

Notes

  • this branch also removes two test files from an earlier branch iteration: internal/filter/strings_test.go and internal/web/handlers_test.go

Validation

  • go test ./...
  • go vet ./...

@Neo23x0 Neo23x0 merged commit c821357 into main Feb 8, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant