Skip to content

Fix review findings: upload safety, job concurrency, and filtering#3

Merged
Neo23x0 merged 1 commit intomainfrom
codex/review-1
Feb 8, 2026
Merged

Fix review findings: upload safety, job concurrency, and filtering#3
Neo23x0 merged 1 commit intomainfrom
codex/review-1

Conversation

@Neo23x0
Copy link
Owner

@Neo23x0 Neo23x0 commented Feb 8, 2026

Summary

  • harden upload handling against path traversal by sanitizing names and constraining writes to the job directory
  • avoid unsafe concurrent reads of mutable jobs by returning cloned snapshots from read endpoints
  • populate job strings from generation output so rule-name suggestion uses real high-scoring strings
  • fix wide-string goodware matching by checking prefixed and unprefixed keys
  • ensure goodware databases are loaded/reloaded when opcode analysis is enabled after prior non-opcode runs

Validation

  • go test ./...
  • go vet ./...

@Neo23x0 Neo23x0 merged commit 03d74bb into main Feb 8, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant