-
Notifications
You must be signed in to change notification settings - Fork 93
Fix alpha emissive visibility and make fog density threshold configurable #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix alpha emissive visibility and make fog density threshold configurable #107
Conversation
…able Fix alpha emissive surfaces not being visible due to timing issue where hasEmissive flag was set before material emissive radiance was calculated in geometry resolver Add configurable waterFogDensityThreshold RTX option with default 0.065f to replace hardcoded value, maintaining Portal RTX compatibility while allowing other games to adjust the threshold Fixes issue where D3D fog end values <= 67 disabled volumetrics entirely
6f8febd to
c32e8f2
Compare
Points to commit fdac3da which includes: Remove artificial distance clamps for physically correct volumetric attenuation Improve plane distance calculations using actual hit positions Better handling of rays extending beyond froxel grid Add explanatory comments for architectural decisions
c32e8f2 to
05188fe
Compare
|
Notes: |
|
REMIX-4508 for tracking |
|
Could you please merge/rebase to the latest main, there're lots of conflicts |
|
Also, did you submit your changes in the RTXDI? You need to merge the changes in RTXDI first, then update the submodule here. |




This PR fixes alpha emissive surfaces not being visible and makes the fog density threshold configurable for better game compatibility.
Alpha Emissive Fix:
Fixed timing issue where hasEmissive flag was set before material emissive radiance was calculated in geometry resolver
Alpha emissive surfaces now properly participate in lighting calculations
Resolves issue where transparent emissive materials were not visible
Fog Density Threshold Configuration:
Add configurable waterFogDensityThreshold RTX option with default 0.065f
Replace hardcoded waterFogDensityThrehold constant in global volumetrics
Maintains Portal RTX compatibility while allowing other games to adjust threshold
Fixes issue where D3D fog end values <= 67 disabled volumetrics entirely
RTXDI Submodule Update:
Updates RTXDI submodule to include volumetric attenuation improvements
Removes artificial distance clamps for physically correct volumetric attenuation
Improves plane distance calculations using actual hit positions
Better handling of rays extending beyond froxel grid maximum distance