Skip to content

Adjust camera aspect ratio on scene load #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julcst wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adjust camera aspect ratio on scene load #482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Source/Falcor/Core/Testbed.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,10 @@ void Testbed::loadScene(const std::filesystem::path& path, SceneBuilder::Flags b
{
mpScene = SceneBuilder(mpDevice, path, Settings(), buildFlags).getScene();

// Adjust the camera aspect ratio.
if (mpScene && mpTargetFBO)
mpScene->setCameraAspectRatio(mpTargetFBO->getWidth() / float(mpTargetFBO->getHeight()));

if (mpRenderGraph)
mpRenderGraph->setScene(mpScene);
}
Expand All @@ -166,6 +170,10 @@ void Testbed::loadSceneFromString(const std::string& scene, const std::string ex
{
mpScene = SceneBuilder(mpDevice, scene.data(), scene.length(), extension, Settings(), buildFlags).getScene();

// Adjust the camera aspect ratio.
if (mpScene && mpTargetFBO)
mpScene->setCameraAspectRatio(mpTargetFBO->getWidth() / float(mpTargetFBO->getHeight()));

if (mpRenderGraph)
mpRenderGraph->setScene(mpScene);
}
Expand Down