Datasets license; swarm readme update [skip ci] (#4303)#4305
Datasets license; swarm readme update [skip ci] (#4303)#4305holgerroth wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Fixes # . ### Description Add datasets 3rd party license; swarm readme update ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Quick tests passed locally by running `./runtest.sh`. - [ ] In-line docstrings updated. - [ ] Documentation updated.
|
/build |
Greptile SummaryThis PR cherry-picks two documentation/license changes from PR #4303: it adds a third-party Apache 2.0 license file for the Hugging Face Key observations:
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[examples/advanced/swarm_learning/README.md] --> B["./swarm_pt/ ❌ (does not exist)"]
A --> C["./swarm_pt/README.md ❌ (does not exist)"]
A --> D["../../tutorials/self-paced-training/part-4.../chapter-7... ✅"]
A --> E["../../tutorials/self-paced-training/README.md ✅"]
Last reviewed commit: a8a1c26 |
|
|
||
| ## Examples | ||
|
|
||
| - **[swarm_pt](./swarm_pt/)** — Swarm learning with LoRA fine-tuning: fine-tune a Qwen2.5 language model using LoRA adapters in a federated setting. See the [swarm_pt README](./swarm_pt/README.md) for setup and run instructions. |
There was a problem hiding this comment.
Broken link to non-existent swarm_pt directory
The README references ./swarm_pt/ and ./swarm_pt/README.md, but the swarm_pt subdirectory does not exist in the repository — the only file under examples/advanced/swarm_learning/ is this README.md itself. Both links on this line will be dead.
If the swarm_pt example is being added in a follow-up PR, it would be safer to add this entry to the README at the same time as the directory, or add a note that the directory is coming soon to avoid confusing readers in the interim.
|
/build |
|
@chesterxgchen let's merge the swarm_pt example into main before merging this PR. |
Fixes # .
Description
Cherry-pick #4303
Types of changes
./runtest.sh.Fixes # .
Description
A few sentences describing the changes proposed in this pull request.
Types of changes
./runtest.sh.