Conversation
| ## Examples | ||
|
|
||
| The following code examples show how each of the three models from Recommendation ITU-R P.2108 can be called from Python. | ||
| The following code examples show how each of the three models from Recommendation ITU-R P.2108 can be called in a C++ program. |
There was a problem hiding this comment.
Good catch, the below code blocks are C++
| Inputs: | ||
| h_tx__meter 0 [meter] | ||
| h_rx__meter 0 [meter] | ||
| h_tx__meter 0 [meters] |
There was a problem hiding this comment.
Plural and lowercase is better here where I think, stating units is usually arbitrary. But this format is correct:
| // rtn is 0 (SUCCESS) | ||
| // result.A_gas__db is approx. 0.1014 dB | ||
| // bending__rad is approx. 8.0309e-05 rad | ||
| // a__km is approx. 115.5221 km |
There was a problem hiding this comment.
Please check if this distance (115.5221 km) is still approximately correct. Some km values have changed above(-115.93 km -> -114.93 km). Also, sorry if these numbers are totally different.
There was a problem hiding this comment.
different model, it was in LFMF, changed from -115.93 dBm to -114.93 dBm
| | | | | radionavigation services using the VHF, UHF, and SHF bands | | ||
| +------------+---------------------------------------+-----------------------+------------------------------------------------------------------+ | ||
| | **P.676** | [Repo](https://github.com/NTIA/P676) | [Docs](models/P676/) | Prediction methods for the specific attenuation, terrestrial and | | ||
| | | | | slant path gaseous attenuation due to oxygen and water vapour | |
There was a problem hiding this comment.
"Vapour" is British spelling where typically write as "Vapor". However, this is considered good, where simply looked weird as haven't seen that spelling.
There was a problem hiding this comment.
Yeah, this follows the P676 and P835 paper. Was thinking change to "Vapor", but everywhere in code is using "Vapour".
models/P676/python.qmd
Outdated
| date-modified: 2025-06-12 | ||
| --- | ||
|
|
||
| This page details the installation and usage of the Python version of the PropLib implementation of the The Recommendation ITU-R P.676-12. |
There was a problem hiding this comment.
Please remove one or both of the "the The" here.
models/P835/python.qmd
Outdated
| date-modified: 2025-06-12 | ||
| --- | ||
|
|
||
| This page details the installation and usage of the Python version of the PropLib implementation of the The Recommendation ITU-R P.835-6. |
There was a problem hiding this comment.
Please remove one or both of the "the The" here.
jodumkeNTIA
left a comment
jodumkeNTIA
left a comment
There was a problem hiding this comment.
Good job, many code examples and example data in code which should help doc readers.
2 participants
Added LFMF dotnet
Added P676
Added P835
Please merge this PR after #4 be released. Also update base branch to main before merging.