refactor: cleanups from dace v2 branch#382
Merged
FlorianDeconinck merged 4 commits intoNOAA-GFDL:developfrom Feb 13, 2026
Merged
refactor: cleanups from dace v2 branch#382FlorianDeconinck merged 4 commits intoNOAA-GFDL:developfrom
FlorianDeconinck merged 4 commits intoNOAA-GFDL:developfrom
Conversation
added 4 commits
February 13, 2026 11:08
Minor cleanup in `Timer` and `NullTimer` classes. Leverage the constructor to initialize `NullTimer` as disabled from the start. No need for `NullTimer` to specialize `enabled()` method.
romanc
force-pushed
the
romanc/cleanups-from-dace-v2-branch
branch
from
50569cb to
83761ec
Compare
| the code for future reference in further optimization. | ||
|
|
||
| WARNING: The Label are passthrough, any use of `simplify` _will remove | ||
| them from the SDFG_ and this is on purpose so there's no tracers of them |
Collaborator
There was a problem hiding this comment.
Ha ha... Atmos brain rot
FlorianDeconinck
approved these changes
Feb 13, 2026
Collaborator
FlorianDeconinck
left a comment
FlorianDeconinck
left a comment
There was a problem hiding this comment.
Thanks for the 🧹
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small PR pulling most of the unrelated changes from the upcoming DaCe v2 update (PR #372).
How has this been tested?
(Assumed to be) Covered by existing tests.
Checklist