Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions automation for catalogbuilder by adding linting to the existing test workflow, introducing an automated semantic-release workflow for versioning/tagging, and wiring conda publishing to run after releases.
Changes:
- Add a pylint step to the existing pip-install + pytest CI workflow.
- Add a new “Semantic Release” workflow to version/tag (and push) on
main. - Change conda publishing to trigger off completion of the “Semantic Release” workflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| .github/workflows/test-pip-install-run-pytest.yml | Adds pylint execution to CI runs. |
| .github/workflows/semantic-release.yml | New workflow to run python-semantic-release and push tags/commits. |
| .github/workflows/publish-conda.yml | Switches conda publish trigger to run after “Semantic Release”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 13 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
|
PR Validation Failed Please select exactly ONE version bump option in the PR template:
Note: The year increments automatically with calendar versioning. |
|
PR Validation Failed Please select exactly ONE version bump option in the PR template:
Note: The year increments automatically with calendar versioning. |
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
|
PR Validation Failed Please select exactly ONE version bump option in the PR template:
Note: The year increments automatically with calendar versioning. |
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
|
PR Validation Failed Please select exactly ONE version bump option in the PR template:
Note: The year increments automatically with calendar versioning. |
|
PR Validation Failed Please select exactly ONE version bump option in the PR template:
Note: The year increments automatically with calendar versioning. |
|
PR Validation Failed Please select exactly ONE version bump option in the PR template:
Note: The year increments automatically with calendar versioning. |
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
|
PR Validation Failed Please select exactly ONE version bump option in the PR template:
Note: The year increments automatically with calendar versioning. |
ceblanton
left a comment
There was a problem hiding this comment.
Ciheim, this update looks excellent and cleans up the standard name lookup as well as a very-slick looking release process.
If you can, please add a test to verify the standard name lookup.
|
PR Validation Failed Please select exactly ONE version bump option in the PR template:
Note: The year increments automatically with calendar versioning. |
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
|
PR Validation Failed Please select exactly ONE version bump option in the PR template:
Note: The year increments automatically with calendar versioning. |
|
PR Validation Failed Please select exactly ONE version bump option in the PR template:
Note: The year increments automatically with calendar versioning. |
|
PR Validation Failed Please select exactly ONE version bump option in the PR template:
Note: The year increments automatically with calendar versioning. |
|
PR Validation Failed Please select exactly ONE version bump option in the PR template:
Note: The year increments automatically with calendar versioning. |
| run: | | ||
| which python | ||
| python catalogbuilder/scripts/gen_intake_gfdl.py archive/am5/am5/am5f3b1r0/c96L65_am5f3b1r0_pdclim1850F/gfdl.ncrc5-deploy-prod-openmp/pp gfdl_autotest | ||
| python catalogbuilder/scripts/gen_intake_gfdl.py archive/am5/am5/am5f3b1r0/c96L65_am5f3b1r0_pdclim1850F/gfdl.ncrc5-deploy-prod-openmp/pp gfdl_autotest --slow |
There was a problem hiding this comment.
Hi Ciheim you mentioned that the pipeline was now running xarray on empty files, and I think this is the cause.
The standard_name lookup uses an offline lookup table, so it doesn't need to open the file with --slow does it?
No description provided.