add a github action to compare the XML outputs between the base branch and the PR branch#1432
Merged
MatthewPyle-NOAA merged 8 commits intoNOAA-EMC:rrfs-mpas-jedifrom Apr 9, 2026
Conversation
…h and the PR branch
Contributor
Author
|
The behavior of this github action can be previewed at the following testing runs: How it fails:https://github.com/guoqing-noaa/rrfs-workflow/actions/runs/24179498356/job/70568612270 How the "ignore" works:https://github.com/guoqing-noaa/rrfs-workflow/actions/runs/24194035253/job/70618846179?pr=12 |
Contributor
Author
|
Tested and worked as expected. Ready for review and merge. Thanks! |
Junjun-NOAA
approved these changes
Apr 9, 2026
MatthewPyle-NOAA
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
Github Actionthat automatically generates a set of Rocoto XML files for different example exp files and different configurations.It serves as a sanity check to ensure that existing capabilities and dependencies continue to function correctly when changes are made to the
setup_rocoto.pyprocess, helping to minimize the need for hotfixes (e.g., #1431).In some cases, differences in the generated XML files are expected—for example, due to version bumps, new features, or other enhancements. In these situations, the GitHub Action will initially fail.
Developers should then manually review and verify the differences. Once all changes are confirmed to be correct, the PR author can update
tests/.ignore.compare_xml_outputsby adding the corresponding PR number to the first line of the file. This signals the GitHub Action to ignore the known differences and pass successfully.This github action only launches when there are any changes to the
setup_rocoto.pyprocess.