Closed
Conversation
felixhekhorn
requested changes
Mar 26, 2026
| # NUTEV neutrino dis | ||
| if kind == "XSNUTEVNU": | ||
| norm = GEV_CM2_CONV * params["GF"] ** 2 * mn / (2.0 * np.pi) | ||
| if kind == "DSIGMADXDQ2": |
Contributor
There was a problem hiding this comment.
- maybe this name is too broad - specifically, I think this only holds for CC, so, e.g.
XS_XQ2_CC? the name is just a suggestion 🙃 but we have usedXSbefore for sigma - this is very close to
XSFPFCC- is there a chance you can reuse that? if not merge at least the two cases together (if A or B:) and then do the split for the different part inside (special_norm = a if A else b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way I do this is pretty simple: I add to
src/yadism/esf/exs.pya new observable, namely the double differential cross section inxandQ2, since yadism has native support for this. If we want to get a fully integrated distriution, this would require substantially more work.I will proceed with adding also some other distributions