Fix NaN accumulation in parallel runs #2416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarlehoff
force-pushed
the
fix_perhaps_nan_issue2322
branch
from
0e822cd to
75b68e7
Compare
Radonirinaunimi
approved these changes
Jan 16, 2026
Member
Radonirinaunimi
left a comment
Radonirinaunimi
left a comment
There was a problem hiding this comment.
Thanks for this! I've experimented with different runs with this and haven't re-encountered the NaN issues. So everything LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a trivial fix for #2322
but testing it is very complicated because it is not very reproducible :(