Conversation
infrastructure/terraform/components/dl/module_sqs_print_status_handler.tf
Outdated
Show resolved
Hide resolved
infrastructure/terraform/components/dl/module_sqs_print_sender.tf
Outdated
Show resolved
Hide resolved
…hub.com/NHSDigital/nhs-notify-digital-letters into feature/CCM-14480_Update_module_sources
| }); | ||
|
|
||
| test.afterAll(async () => { | ||
| await purgeQueue(FILE_SCANNER_DLQ_NAME); |
There was a problem hiding this comment.
Is this needed? We are running it in beforeAll to make sure that any existing messages don't interfere with expectMessageContainingString (it only fetches 10).
There was a problem hiding this comment.
I added it to keep things tidy, but it’s not really needed and could actually hide problems. I’ll remove it.
| aws = aws | ||
| aws.us-east-1 = aws.us-east-1 | ||
| } | ||
| source = "https://github.com/NHSDigital/nhs-notify-shared-modules/releases/download/3.0.1/terraform-kms.zip" |
There was a problem hiding this comment.
3.0.4 is the latest tag on the notify-shared-modules repository
There was a problem hiding this comment.
Cheers, I'll bump it to 3.0.4
There was a problem hiding this comment.
This one's got a hardcoded max_receive_count value. Any reason it shouldn't use the variable?
There was a problem hiding this comment.
print-sender, print-analyser and print-status-handler are all intentionally hardcoded to 1, as retries wouldn't add much value if they fail. See above.
There was a problem hiding this comment.
Another one with a fixed max_receive_count.
aidenvaines-cgi
dismissed
their stale review
theres some variable names that are unhappy
4 participants
Description
This PR adds a tool to update all Terraform module sources, updates DLQ configuration and related tests.
Context
Component test suite now runs approximately 2 minutes 30 seconds faster.
Before:
After:
Dry run output:
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.