Open
Conversation
nhsd-angel-pastor
force-pushed
the
feature/CCM-13304_generate_reports
branch
from
0da8129 to
bab96e7
Compare
… back to recordId from SQS
simonlabarere
force-pushed
the
feature/CCM-13304_generate_reports
branch
from
ae5f4af to
4f2f398
Compare
Ian-Hodges
reviewed
Mar 3, 2026
infrastructure/terraform/components/dl/module_s3bucket_reporting.tf
Outdated
Show resolved
Hide resolved
Ian-Hodges
reviewed
Mar 3, 2026
Ian-Hodges
reviewed
Mar 3, 2026
Comment on lines
+116
to
+117
| logger.error({ err: result.reason }); | ||
| processed.failed += 1; |
Contributor
There was a problem hiding this comment.
These are not covered by unit tests. If we can get them tested we can remove the coverage thresholds in the jest config file.
Ian-Hodges
reviewed
Mar 3, 2026
| const { reportDate, senderId } = event.data; | ||
|
|
||
| try { | ||
| const query = fs.readFileSync('/var/task/queries/report.sql', 'utf8'); |
Contributor
There was a problem hiding this comment.
Is this the pattern we've followed else where? The reports in core use saved athena queries rather than a local file.
Contributor
Author
There was a problem hiding this comment.
Yes I copied this from core but happy to start using saved queries.
Ian-Hodges
previously approved these changes
Mar 3, 2026
gareth-allan
reviewed
Mar 4, 2026
Comment on lines
+157
to
+168
| statement { | ||
| sid = "SQSDLQPermissions" | ||
| effect = "Allow" | ||
|
|
||
| actions = [ | ||
| "sqs:SendMessage", | ||
| ] | ||
|
|
||
| resources = [ | ||
| module.sqs_report_generator.sqs_dlq_arn, | ||
| ] | ||
| } |
Contributor
There was a problem hiding this comment.
Do we need these permissions now we're not sending directly to the DLQ?
| { | ||
| "dependencies": { | ||
| "@aws-sdk/client-athena": "^3.984.0", | ||
| "@aws-sdk/client-sqs": "^3.984.0", |
Contributor
There was a problem hiding this comment.
Not sure we need this if we're no longer sending events directly to the DLQ.
| | **Uk.nhs.notify.digital.letters.print.printed.v1** | [`../../output/digital-letters/2025-10-draft/example-events/uk.nhs.notify.digital.letters.print.printed.v1-event.json`](../../output/digital-letters/2025-10-draft/example-events/uk.nhs.notify.digital.letters.print.printed.v1-event.json) | [`../../output/digital-letters/2025-10-draft/example-events/uk.nhs.notify.digital.letters.print.printed.v1-event.md`](../../output/digital-letters/2025-10-draft/example-events/uk.nhs.notify.digital.letters.print.printed.v1-event.md) | | ||
| | **Uk.nhs.notify.digital.letters.queue.item.dequeued.v1** | [`../../output/digital-letters/2025-10-draft/example-events/uk.nhs.notify.digital.letters.queue.item.dequeued.v1-event.json`](../../output/digital-letters/2025-10-draft/example-events/uk.nhs.notify.digital.letters.queue.item.dequeued.v1-event.json) | [`../../output/digital-letters/2025-10-draft/example-events/uk.nhs.notify.digital.letters.queue.item.dequeued.v1-event.md`](../../output/digital-letters/2025-10-draft/example-events/uk.nhs.notify.digital.letters.queue.item.dequeued.v1-event.md) | | ||
| | **Uk.nhs.notify.digital.letters.queue.item.enqueued.v1** | [`../../output/digital-letters/2025-10-draft/example-events/uk.nhs.notify.digital.letters.queue.item.enqueued.v1-event.json`](../../output/digital-letters/2025-10-draft/example-events/uk.nhs.notify.digital.letters.queue.item.enqueued.v1-event.json) | [`../../output/digital-letters/2025-10-draft/example-events/uk.nhs.notify.digital.letters.queue.item.enqueued.v1-event.md`](../../output/digital-letters/2025-10-draft/example-events/uk.nhs.notify.digital.letters.queue.item.enqueued.v1-event.md) | | ||
| | **Uk.nhs.notify.digital.letters.queue.item.removed.v1** | [`../../output/digital-letters/2025-10-draft/example-events/uk.nhs.notify.digital.letters.queue.item.removed.v1-event.json`](../../output/digital-letters/2025-10-draft/example-events/uk.nhs.notify.digital.letters.queue.item.removed.v1-event.json) | [`../../output/digital-letters/2025-10-draft/example-events/uk.nhs.notify.digital.letters.queue.item.removed.v1-event.md`](../../output/digital-letters/2025-10-draft/example-events/uk.nhs.notify.digital.letters.queue.item.removed.v1-event.md) | |
Contributor
There was a problem hiding this comment.
Shouldn't we have a new entry for uk.nhs.notify.digital.letters.queue.digital.letter.read.v1
Contributor
Author
There was a problem hiding this comment.
I might need some help figuring out what's missing here! I see that it's missing from src/cloudevents/readme-index.yaml but I'm not sure what else should be added.
simonlabarere
added
skip-trivy-package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Generate report component.
Testing
Generate Report Event
Report Generated in S3
Report Generated Event
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.