-
Notifications
You must be signed in to change notification settings - Fork 3
CCM-13278: Confirm that we have received a file from a Trust #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f65e817 to
5e39535
Compare
4ec46d3 to
9bc8e6c
Compare
18fb2ca to
99a2f39
Compare
99a2f39 to
b1a6b60
Compare
infrastructure/terraform/components/dl/module_lambda_mesh_acknowledge.tf
Outdated
Show resolved
Hide resolved
infrastructure/terraform/components/dl/module_sqs_mesh_acknowledge.tf
Outdated
Show resolved
Hide resolved
gareth-allan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor post-merge comments.
utils/sender-management/sender_management/__tests__/test_sender_lookup.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised the python event publisher is doing anything with mesh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is now moved to a utility package for Python projects.
|
See #186 |
Description
This PR adds the MESH Acknowledger component.
meshMessageIdfield to theMESHInboxMessageDownloadedeventsrc/python-schema-generatorsender_lookup.pyfile added to the mesh-poll lambda in CCM-12616 mesh poll retrieve #104 to thesender-managementpackage that currently contains the TypeScript sender management librarydigital-letters-eventspackage, where we have both TS and Python packages in a single directorypackage_python_lambda.shscript toutilsContext
Notify is documented as providing acknowledgement messages in response to MESH messages received. This provides confirmation that a request was successfully received. Since the integrator response is documented publicly, users of Digital Letters are likely to expect it, given they will be unaware that we’re operating within a bounded context that doesn’t include all of Core’s functionality, so we should implement the same functionality in Digital Letters.
Validation
To check that publishing directly to the DLQ works, I manually updated the configuration of the mesh-acknowledge lambda to set an incorrect event bridge ARN and event bridge DLQ URL and then used the Lambda's "test" function to send a valid message downloaded event. This resulted in the event publishing and DLQ-ing failing, and so the function pushed the record directly to the DLQ:



Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.