Skip to content

Conversation

@JamesW1-NHS
Copy link
Contributor

@JamesW1-NHS JamesW1-NHS commented Aug 21, 2025

Summary

  • Routine Change

Small fix to VED-124 after e2e testing.
The ack files contain a header row. Therefore the actual number of rows processed is row_count - 1, not row_count.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

@github-actions
Copy link
Contributor

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-124

@sonarqubecloud
Copy link

@JamesW1-NHS JamesW1-NHS merged commit 9f6b8a1 into master Aug 21, 2025
8 checks passed
@JamesW1-NHS JamesW1-NHS deleted the VED-124-Batch_Splunk-buglet branch August 21, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants