Conversation
|
Hello @mkelley! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2025-01-15 13:22:57 UTC |
|
Thank you for your contribution to sbpy, an Astropy affiliated package! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
👋 Thank you for your draft pull request! Do you know that you can use |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
==========================================
+ Coverage 84.72% 84.90% +0.17%
==========================================
Files 92 100 +8
Lines 8459 8616 +157
==========================================
+ Hits 7167 7315 +148
- Misses 1292 1301 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b905d31 to
aa896f1
Compare
25d7e6a to
5315e23
Compare
5315e23 to
8461d79
Compare
7b8b265 to
833e066
Compare
… testing coverage.
New surfaces module, addressing the first step in issue #415.
This PR defines the API for surfaces via the
Surfaceclass, and provides support for sunlight scattering off a Lambertian surface:Surfaceclass require four methods:LambertianSurfaceclass defines absorptance, emittance, and reflectance for a surface that uniformly scatters light in all directions.ScatteredLightdefines radiance for a surface scattering a light source.ScatteredSunlightaddsscattered_sunlight, which is used to calculate the radiance from a surface scattering sunlight. It is mainly for user convenience.See the documentation for more.
I'm open to any suggestions, especially if improvements in the names and terminology are needed.