Fix out-of-bounds UB in getNumber: log full number string instead of number[1]#133
Merged
rrivera747 merged 2 commits intorrivera/add-orsingleshotmode-bitsfrom Mar 23, 2026
Merged
Conversation
…[1]` Co-authored-by: rrivera747 <107584474+rrivera747@users.noreply.github.com> Agent-Logs-Url: https://github.com/Mu2e/mu2e-pcie-utils/sessions/91176b2e-cf96-4cf0-9331-3b5323080ce8
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on 'Rrivera/add orsingleshotmode bits' PR
Fix out-of-bounds UB in Mar 23, 2026
getNumber: log full number string instead of number[1]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getNumberinCFO_Compiler.cpploggednumber[1]via__COUTVS__before any bounds check, causing out-of-bounds access and undefined behavior for single-character tokens (e.g."5").Change
__COUTVS__(2, number[1])with__COUTVS__(2, number)in both integer and fallback branches ofgetNumber⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.