Fix release (and double release) of mu2e PCIe device by destructors f…

[rrivera747]

…rom class hierarchy of CFO/DTC

[Copilot]

Pull request overview

This PR fixes the release (and double release) of the mu2e PCIe device by moving cleanup logic into mu2edev::close() and calling it from the mu2edev destructor, removing redundant device_.close() calls from derived class destructors. It also adds munmap cleanup, improves version mismatch error handling for CFO, and adds diagnostic logging.

Changes:

• Moved device_.close() from CFOandDTC_Registers and CFO_Registers destructors into mu2edev::~mu2edev(), and enhanced close() to properly munmap before closing the file descriptor
• Added try/catch around std::stoul for CFO version parsing (matching existing DTC pattern), with device index in error messages
• Initialized devfd_ to -1 and fixed the sentinel value check/reset from 0 to -1

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
dtcInterfaceLib/mu2edev.h	Initialize devfd_ to -1
dtcInterfaceLib/mu2edev.cpp	Add close() call in destructor, add munmap in close(), use -1 sentinel for devfd_, add logging
dtcInterfaceLib/CFOandDTC_Registers.cpp	Remove device_.close() from destructor (now handled by mu2edev)
cfoInterfaceLib/CFO_Registers.cpp	Remove device_.close() from destructor; add robust version parsing with try/catch
dtcInterfaceLib/DTC_Registers.cpp	Add device index to version mismatch error messages, bump destructor log level

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.