Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Fixes #3484 Fixes URL bar selection ranges #3505

Merged
bluemarvin merged 1 commit into from
Jun 15, 2020
Merged

Fixes #3484 Fixes URL bar selection ranges #3505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/src/common/shared/org/mozilla/vrbrowser/ui/views/NavigationURLBar.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,12 @@ private void showSelectionMenu() {
public void onAction(String action) {
int startSelection = mBinding.urlEditText.getSelectionStart();
int endSelection = mBinding.urlEditText.getSelectionEnd();
boolean selectionValid = endSelection > startSelection;
boolean selectionValid = endSelection != startSelection;
if (startSelection > endSelection) {
int tmp = endSelection;
endSelection = startSelection;
startSelection = tmp;
}

if (action.equals(GeckoSession.SelectionActionDelegate.ACTION_CUT) && selectionValid) {
String selectedText = mBinding.urlEditText.getText().toString().substring(startSelection, endSelection);
Expand Down