This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Use checks API in taskcluster#3355
Merged
bluemarvin merged 1 commit intoMozillaReality:masterfrom May 19, 2020
Merged
Conversation
owlishDeveloper
force-pushed
the
use-checks
branch
from
379fe03 to
16e1cab
Compare
Contributor
Author
|
One thing to note is the cute cat badge is going to break with this API |
Contributor
Should it just be removed or is there an alternative? |
Contributor
Author
There's no alternative, unfortunately |
Contributor
So remove the |
bluemarvin
approved these changes
May 13, 2020
Contributor
|
Depends on #3372 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I heard from @bluemarvin that when a taskcluster task is re-triggered, the status on github doesn't change. That can be changed if a newer checks API is used. This PR does exactly that
(It is draft for now because I need to see which scopes are missing)ok, it actually seems to work!
As you can see, using a different taskcluster API also changes UX here a bit. You will notice there's a Checks tab up top - that's where the "Details" link will be pointing at now. This can always be changed back.