Fixes #2424 Enhanced Tracking Protection#3037
Conversation
|
There are a few common issues with the WebXR settings PR:
I'll fix those when I rebase this one with the pending PRs. |
| .antiTracking(ContentBlocking.AntiTracking.AD or ContentBlocking.AntiTracking.SOCIAL or ContentBlocking.AntiTracking.ANALYTIC) | ||
| .antiTracking( | ||
| ContentBlocking.AntiTracking.AD or | ||
| ContentBlocking.AntiTracking.SOCIAL or | ||
| ContentBlocking.AntiTracking.ANALYTIC) | ||
| .enhancedTrackingProtectionLevel(SettingsStore.getInstance(context).trackingProtectionLevel) |
There was a problem hiding this comment.
I think we only want one or the other set at one time?
There was a problem hiding this comment.
These are independent, actually. antiTracking controls what content gets blocked when GeckoSessionSettings.useTrackingProtection is true, while enhancedTrackingProtectionLevel controls what cookies get blocked when our cookie behavior is ACCEPT_NON_TRACKERS.
There was a problem hiding this comment.
The way I understood what was explained to me is that we only want one active at a time. If we are blocking cookies we don't want to be blocking content as that is the purpose of ETP, it just blocks the tracking cookies and the content is all loaded which reduce breakage, where content blocking is more strict but also causes more breakage.
There was a problem hiding this comment.
These are independent, actually.
antiTrackingcontrols what content gets blocked whenGeckoSessionSettings.useTrackingProtectionis true, whileenhancedTrackingProtectionLevelcontrols what cookies get blocked when our cookie behavior isACCEPT_NON_TRACKERS.
@droeh I guess I'm still confused, I don't see GeckoSessionSettings.useTrackingProtection() except when the session is created. Does this mean it never gets turned off?
There was a problem hiding this comment.
Sorry for the slow reponse, I'm not used to getting work mail from github!
There are cases where you might want to leave ETP and TP both enabled, for example you may want to enable TP only for one category and ETP for the rest. In general they are only exposed in UI mutually exclusively, though (eg as "Standard" and "Strict" in desktop).
And yeah, I missed that, but you definitely need to update GeckoSessionSettings.useTrackingProtection() to control TP, and do it for every session. (Yes, that sucks, it's on the list of things to change in the API.)
I'll keep an eye on github mail and respond quicker if you have any more questions.
droeh
left a comment
droeh
left a comment
There was a problem hiding this comment.
The tracking protection related stuff looks good to me.
| .antiTracking(ContentBlocking.AntiTracking.AD or ContentBlocking.AntiTracking.SOCIAL or ContentBlocking.AntiTracking.ANALYTIC) | ||
| .antiTracking( | ||
| ContentBlocking.AntiTracking.AD or | ||
| ContentBlocking.AntiTracking.SOCIAL or | ||
| ContentBlocking.AntiTracking.ANALYTIC) | ||
| .enhancedTrackingProtectionLevel(SettingsStore.getInstance(context).trackingProtectionLevel) |
There was a problem hiding this comment.
These are independent, actually. antiTracking controls what content gets blocked when GeckoSessionSettings.useTrackingProtection is true, while enhancedTrackingProtectionLevel controls what cookies get blocked when our cookie behavior is ACCEPT_NON_TRACKERS.
|
@keianhzo droeh says this is the site to use for testing: https://senglehardt.com/test/trackingprotection/test_pages/ |
|
@bluemarvin @droeh I've rebased and removed all redundant code. I've been testing with the site above and I think the results are good, also are the sames as Fenix. |
|
Seems to work from my testing. It would be nice if we could do a v2 where the shield changed colors when it actually blocks some thing and then clicking on that would give more details on what was blocked. |
bluemarvin
left a comment
bluemarvin
left a comment
There was a problem hiding this comment.
Okay, I'm not sure it is actually working:
I turned off tracking protection:
But it says tracking protection is still on and cookies are still getting blocked:
|
I wonder if we should even show the shield if tracking protection is turned off. |
|
@bluemarvin Regarding:
I see the same behavior in Fenix, maybe @droeh can clarify. And regarding:
I'll look into that tomorrow |
|
@bluemarvin updated with hiding the tracking protection icon if disabled. |
bluemarvin
left a comment
bluemarvin
left a comment
There was a problem hiding this comment.
Will file follow up for GV issue https://bugzilla.mozilla.org/show_bug.cgi?id=1625210
|
Follow up issue #3053 |
3 participants
Fixes #2424 Enhanced Tracking Protection