Skip to content

Fix collect and merge xcdatamodel correctly for mixed_language_library targets#3268

Merged
brentleyjones merged 1 commit intomainfrom
luis/fix-mixed-lib-xcdatamodel
Feb 5, 2026
Merged

Fix collect and merge xcdatamodel correctly for mixed_language_library targets#3268
brentleyjones merged 1 commit intomainfrom
luis/fix-mixed-lib-xcdatamodel

Conversation

@luispadron
Copy link
Contributor

@luispadron luispadron commented Feb 5, 2026

Fixes #3267

@luispadron luispadron marked this pull request as ready for review February 5, 2026 18:29
@luispadron luispadron requested review from a team as code owners February 5, 2026 18:29
@luispadron luispadron changed the title fix: collect and merge xcdatamodel correctly for mixed_language_library targets Fix collect and merge xcdatamodel correctly for mixed_language_library targets Feb 5, 2026
@luispadron luispadron force-pushed the luis/fix-mixed-lib-xcdatamodel branch from 1354fd4 to bed0380 Compare February 5, 2026 18:46
@luispadron luispadron force-pushed the luis/fix-mixed-lib-xcdatamodel branch from bed0380 to 71b99bf Compare February 5, 2026 19:07
@luispadron
Copy link
Contributor Author

Closing in favor of proper fix: bazelbuild/rules_swift#1654

@luispadron luispadron closed this Feb 5, 2026
@luispadron luispadron reopened this Feb 5, 2026
…ry` targets

Signed-off-by: Luis Padron <lpadron@squareup.com>
@luispadron luispadron force-pushed the luis/fix-mixed-lib-xcdatamodel branch from 71b99bf to e71aa38 Compare February 5, 2026 19:52
@luispadron
Copy link
Contributor Author

Just kidding we still need this but we can use just the mixed_target_infos once bazelbuild/rules_swift#1654 lands

@brentleyjones brentleyjones merged commit 4942418 into main Feb 5, 2026
9 of 11 checks passed
@brentleyjones brentleyjones deleted the luis/fix-mixed-lib-xcdatamodel branch February 5, 2026 21:14
brentleyjones pushed a commit that referenced this pull request Feb 10, 2026
Fix after #3268, requires
bazelbuild/rules_apple#2880

Signed-off-by: Luis Padron <lpadron@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Latest xccurrentversion not being collected from data attr of a mixed_language_library target

3 participants