fix: Only use IPv4 address without dual mode#44
Open
imerr wants to merge 1 commit intoMirrorNetworking:masterfrom
Open
fix: Only use IPv4 address without dual mode#44imerr wants to merge 1 commit intoMirrorNetworking:masterfrom
imerr wants to merge 1 commit intoMirrorNetworking:masterfrom
Conversation
Previously, if the DNS resolve returned an IPv6 address as the first entry it would use that Notable for connecting to "localhost" which resolves to ::1 (ipv6) first on windows
Collaborator
Contributor
Author
|
Even though you connect to the right address family, the server might not be listening on that address family For example the case of connecting to "localhost" with dual mode off |
d6ae9fe to
eeb25ed
Compare
ec826db to
5e2ef37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Previously, if the DNS resolve returned an IPv6 address as the first entry it would use that Notable for connecting to "localhost" which resolves to ::1 (ipv6) first on windows