fix: Guild Member List & Guild Search Lists are now fully clickable + Grid fixes#13
Merged
Boy0000 merged 4 commits intoMineInAbyss:masterfrom Jan 24, 2026
Merged
fix: Guild Member List & Guild Search Lists are now fully clickable + Grid fixes#13Boy0000 merged 4 commits intoMineInAbyss:masterfrom
Boy0000 merged 4 commits intoMineInAbyss:masterfrom
Conversation
Previously the grid would give an extra line if the placeables was evenly divisible by itemsPerLine.
Previously, the guild member list menus had the rightmost and bottommost column/row (respectively) not be clickable. This occured because the contents (usually a Grid) was offset and the Box containing them was not. This has been resolved through and admitedly hacky solution where: 1) A box is rendered as before and used to fetch the size of the contents (Grid) 2) A box is rendered whose components are blank cells to clear out step (1) 3) The final box is rendered using fillMaxSize() to ensure that the contents fit inside it. This separates the size extraction and the content containing steps. This ensures that: - The 'itemsPerPage' or 'itemsPerLine' and 'totalLines' variables are of the size of the original contents instead of their enclosing Box. - The enclosing box for the contents is of sufficient size such that all the elements are clickable. Alternative solutions could include altering the spec for Scrollable and Paginated to take in an optional Size override.
Member
|
I can cherry pick the width and height fixes into the 1.21.4 branch, however the double composition of |
Contributor
Author
|
Sounds good. We can revisit once you finish the guild implementation cleanup! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces two fixes: one for the Guild Menu and one for Grid in general
Copying my commit messages here:
Grid
Previously the grid would give an extra line if the placeables
was evenly divisible by itemsPerLine.
Guild Menu
Previously, the guild member list menus had the rightmost and
bottommost column/row (respectively) not be clickable. This occured
because the contents (usually a Grid) was offset and the Box containing
them was not.
This has been resolved through and admitedly hacky solution where:
fit inside it.
This separates the size extraction and the content containing steps.
This ensures that:
The 'itemsPerPage' or 'itemsPerLine' and 'totalLines' variables
are of the size of the original contents instead of their enclosing Box.
The enclosing box for the contents is of sufficient size such that all
the elements are clickable.
Alternative solutions could include altering the spec for Scrollable and
Paginated to take in an optional Size override.