Skip to content

Fixed check that pop via gesture ignored subroutes#1941

Open
iagoandrei wants to merge 1 commit intoMilad-Akarie:masterfrom
iagoandrei:master
Open

Fixed check that pop via gesture ignored subroutes#1941
iagoandrei wants to merge 1 commit intoMilad-Akarie:masterfrom
iagoandrei:master

Conversation

@iagoandrei
Copy link
Copy Markdown
Contributor

@iagoandrei iagoandrei commented Apr 23, 2024

Fixes: #1932

In the previous PR(#1940) I did not consider when the AutoRouter() widget is not used to build nested routes. This PR corrects the situation when AutoRouter() is not used to build routes.

@iagoandrei
Copy link
Copy Markdown
Contributor Author

@Milad-Akarie According to my tests everything looks fine on both platforms now. Please check if it is correct.

@jtdLab
Copy link
Copy Markdown
Contributor

jtdLab commented Apr 23, 2024

LGTM

@Den-creator
Copy link
Copy Markdown

Will it fix issue when whole stack is popped instead if one page by swipe back ?

@jtdLab
Copy link
Copy Markdown
Contributor

jtdLab commented Apr 24, 2024

Will it fix issue when whole stack is popped instead if one page by swipe back ?

Yep

@Den-creator
Copy link
Copy Markdown

Cool. When it will be merged ?

@iagoandrei
Copy link
Copy Markdown
Contributor Author

Cool. When it will be merged ?

Waiting for the review @Milad-Akarie

@iagoandrei
Copy link
Copy Markdown
Contributor Author

Please review this PR @Milad-Akarie

@Milad-Akarie
Copy link
Copy Markdown
Owner

Hey @iagoandrei checking the routing controller stack for pop possibility is not reliably because of pageless routes, can you check if the fix I released is working for you?

@gidrokolbaska
Copy link
Copy Markdown

Hey @iagoandrei checking the routing controller stack for pop possibility is not reliably because of pageless routes, can you check if the fix I released is working for you?

Doesn't work for me on the latest 8.1.2

@Milad-Akarie
Copy link
Copy Markdown
Owner

8.1.3 will be uploaded soon

@gidrokolbaska
Copy link
Copy Markdown

8.1.3 will be uploaded soon

yep, can confirm that now it works properly. @iagoandrei can you please also check that it works for you on the latest 8.1.3?

@ziqq
Copy link
Copy Markdown

ziqq commented May 3, 2024

Not fixed: #1940

imageimage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can not swipe back on iOS when using nested navigation

6 participants