Skip to content

chore: Add npm script for auto-fixing dependency lint issues#268

Merged
Gudahtt merged 1 commit intomainfrom
create-dependency-fix-script
Aug 12, 2025
Merged

chore: Add npm script for auto-fixing dependency lint issues#268
Gudahtt merged 1 commit intomainfrom
create-dependency-fix-script

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Aug 8, 2025

This matches what we use in core. Previously lint would actually run yarn dedupe and modify the lockfile, which is certainly not what I would expect from a lint command.

Examples

https://github.com/MetaMask/core/blob/686a26ab125431f2f9cdb37ccbb28a96713e14f4/package.json#L27

@Gudahtt Gudahtt requested a review from a team August 8, 2025 13:26
Copy link
Copy Markdown
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

This matches what we use in `core`. Previously `lint` would actually
run `yarn dedupe` and modify the lockfile, which is certainly not what
I would expect from a lint command.
@Gudahtt Gudahtt force-pushed the create-dependency-fix-script branch from f31c9d4 to bcdd93c Compare August 8, 2025 14:24
Copy link
Copy Markdown

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 824d16c into main Aug 12, 2025
22 checks passed
@Gudahtt Gudahtt deleted the create-dependency-fix-script branch August 12, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants