You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
consume the published @metamask/ramps-controller preview build from MetaMask/core#8596
keep this isolated on top of the existing mobile companion branch so we can validate the packaged artifact without muddying the feature PR
align @metamask/messenger onto ^1.2.0 via dependencies and resolutions so the preview package does not introduce a second nominally-incompatible Messenger type into the mobile tree
Why
Amitab asked us to publish a preview of the core PR and validate it from mobile. When I first switched mobile to @metamask-previews/[email protected], yarn lint:tsc failed because mobile resolved two different @metamask/messenger versions (1.1.1 and 1.2.0). Since Messenger has a private field, TypeScript treats those versions as incompatible nominal types. This PR shows the minimal consumer-side alignment needed for the previewed ramps package to typecheck cleanly.
This PR targets saustrie-consensys/TRAM-3475-circuit-breaker-open-error intentionally, so the diff stays focused on the preview-consumer changes only.
Local lint:tsc also requires the repo's generated app/util/termsOfUse/termsOfUseContent.ts artifact to exist, which is already present in the main mobile worktree and is generated by scripts/setup.mjs in clean environments.
E2E Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/ramps-controller. Running all tests.
Performance Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/ramps-controller. Running all tests.
✅ E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user). View details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metamaskbotv2
Bot
added
the
team-money-movement
saustrie-consensys
force-pushed
the
saustrie-consensys/TRAM-3475-mobile-preview-consumer
branch
from
Summary
@metamask/ramps-controllerpreview build fromMetaMask/core#8596@metamask/messengeronto^1.2.0viadependenciesandresolutionsso the preview package does not introduce a second nominally-incompatibleMessengertype into the mobile treeWhy
Amitab asked us to publish a preview of the core PR and validate it from mobile. When I first switched mobile to
@metamask-previews/[email protected],yarn lint:tscfailed because mobile resolved two different@metamask/messengerversions (1.1.1and1.2.0). SinceMessengerhas a private field, TypeScript treats those versions as incompatible nominal types. This PR shows the minimal consumer-side alignment needed for the previewed ramps package to typecheck cleanly.Validation
yarn installyarn lint:tsc./node_modules/.bin/jest --runTestsByPath app/components/UI/Ramp/utils/parseUserFacingError.test.ts app/components/UI/Ramp/hooks/useRampsProviders.test.ts app/components/UI/Ramp/hooks/useRampsCountries.test.ts app/components/UI/Ramp/hooks/useRampsTokens.test.ts app/components/UI/Ramp/hooks/useRampsPaymentMethods.test.ts --runInBandNotes
saustrie-consensys/TRAM-3475-circuit-breaker-open-errorintentionally, so the diff stays focused on the preview-consumer changes only.lint:tscalso requires the repo's generatedapp/util/termsOfUse/termsOfUseContent.tsartifact to exist, which is already present in the main mobile worktree and is generated byscripts/setup.mjsin clean environments.