Skip to content

feat: add Tempo chain as additionnal network#29515

Open
maxime-oe wants to merge 1 commit intomainfrom
feat/add-tempo-as-additionnal-network
Open

feat: add Tempo chain as additionnal network#29515
maxime-oe wants to merge 1 commit intomainfrom
feat/add-tempo-as-additionnal-network

Conversation

@maxime-oe
Copy link
Copy Markdown
Contributor

@maxime-oe maxime-oe commented Apr 29, 2026

Description

Changelog

CHANGELOG entry: add Tempo chain to the additional networks list

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/NEB-1098?atlOrigin=eyJpIjoiNTExNzIwM2EwYjc5NDdkMmFiMTkwY2VmMzhmODllNzAiLCJwIjoiaiJ9

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

image

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Small, additive change that only extends the static popular-network configuration and its test; main risk is misconfigured RPC/explorer metadata or missing image asset.

Overview
Adds the Tempo network to PopularList, including chainId 0x1079 (4217), RPC endpoint, block explorer URL, ticker (USD), warning flag, and a bundled logo (tempo.png) so it appears in the additional network selection.

Updates the popular network chainId unit test to assert the new Tempo entry is present and correctly encoded.

Reviewed by Cursor Bugbot for commit 0a83f05. Bugbot is set up for automated code reviews on this repo. Configure here.

@maxime-oe maxime-oe marked this pull request as ready for review April 29, 2026 18:31
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-networks Networks team label Apr 29, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 36c3d98. Configure here.

Comment thread app/util/networks/customNetworks.tsx Outdated
@maxime-oe maxime-oe force-pushed the feat/add-tempo-as-additionnal-network branch from 36c3d98 to 05a8fdb Compare April 29, 2026 19:43
@maxime-oe maxime-oe force-pushed the feat/add-tempo-as-additionnal-network branch from 05a8fdb to 0a83f05 Compare April 29, 2026 21:21
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeNetworkAbstractions
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 92%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are purely additive - a new "Tempo" network (chainId 4217) is added to the PopularList in customNetworks.tsx, along with a corresponding unit test update. This is a data-only change following the exact same pattern as existing popular networks (MegaETH, HyperEVM, Monad, etc.).

The PopularList is consumed by:

  • Network management UI (adding popular networks) → SmokeNetworkAbstractions
  • Token filtering, bridge/swap destination networks, asset overview (secondary consumers)

SmokeNetworkAbstractions directly tests "adding popular networks" flows including viewing available networks, selecting/deselecting networks, and managing network enabled state - which is exactly what this change affects.

No other tags are warranted because:

  • No controller logic changes (no SmokeConfirmations, SmokeWalletPlatform needed)
  • No swap/bridge logic changes (no SmokeTrade needed)
  • No multi-chain provider changes (no SmokeNetworkExpansion, SmokeMultiChainAPI needed)
  • No account management changes (no SmokeAccounts, SmokeIdentity needed)
  • The change is purely additive data with no behavioral changes to existing flows

Performance Test Selection:
This is a pure data addition (one new network entry in an array). There are no UI rendering changes, no new components, no state management changes, and no performance-sensitive code paths modified. The PopularList is a static array that is iterated at render time, but adding one more entry has negligible performance impact.

View GitHub Actions results

@github-actions
Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
12 value mismatches detected (expected — fixture represents an existing user).
View details

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant