Merged
Conversation
shane-t
previously approved these changes
Apr 30, 2026
f4fcb83 to
27bcd4b
Compare
shane-t
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR updates the ChompApiService:createUpgrade call in money-account-upgrade-controller to correct some errors that were revealed in testing. These changes have been verified in the mobile repo, and the step now completes successfully.
References
Checklist
Note
Medium Risk
Touches the account-upgrade flow and changes the wire format sent to
ChompApiService:createUpgrade, which could affect upgrade success if mismatched with backend expectations; scope is small and covered by updated tests.Overview
Fixes the EIP-7702 authorization step to submit the CHOMP upgrade request with correct parameters: using
delegatorImplAddress(not the signer EOA) asaddress, and sendingchainIdplus a0x-prefixed hexnonce(not decimal strings).Updates unit tests to match the new request shape and documents the fix in the package changelog.
Reviewed by Cursor Bugbot for commit 27bcd4b. Bugbot is set up for automated code reviews on this repo. Configure here.