Skip to content

feat: fix errors in eip-7702 step#8657

Merged
Jwhiles merged 2 commits intomainfrom
pass-chain-id-as-hex-to-chomp
Apr 30, 2026
Merged

feat: fix errors in eip-7702 step#8657
Jwhiles merged 2 commits intomainfrom
pass-chain-id-as-hex-to-chomp

Conversation

@Jwhiles
Copy link
Copy Markdown
Contributor

@Jwhiles Jwhiles commented Apr 30, 2026

Explanation

This PR updates the ChompApiService:createUpgrade call in money-account-upgrade-controller to correct some errors that were revealed in testing. These changes have been verified in the mobile repo, and the step now completes successfully.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Touches the account-upgrade flow and changes the wire format sent to ChompApiService:createUpgrade, which could affect upgrade success if mismatched with backend expectations; scope is small and covered by updated tests.

Overview
Fixes the EIP-7702 authorization step to submit the CHOMP upgrade request with correct parameters: using delegatorImplAddress (not the signer EOA) as address, and sending chainId plus a 0x-prefixed hex nonce (not decimal strings).

Updates unit tests to match the new request shape and documents the fix in the package changelog.

Reviewed by Cursor Bugbot for commit 27bcd4b. Bugbot is set up for automated code reviews on this repo. Configure here.

@Jwhiles Jwhiles marked this pull request as ready for review April 30, 2026 14:47
@Jwhiles Jwhiles requested review from a team as code owners April 30, 2026 14:47
shane-t
shane-t previously approved these changes Apr 30, 2026
@Jwhiles Jwhiles enabled auto-merge April 30, 2026 15:08
@Jwhiles Jwhiles force-pushed the pass-chain-id-as-hex-to-chomp branch from f4fcb83 to 27bcd4b Compare April 30, 2026 15:15
@Jwhiles Jwhiles added this pull request to the merge queue Apr 30, 2026
Merged via the queue into main with commit cf9ad5e Apr 30, 2026
366 checks passed
@Jwhiles Jwhiles deleted the pass-chain-id-as-hex-to-chomp branch April 30, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants