Closed
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Prithpal-Sooriya
previously approved these changes
Nov 3, 2025
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
bergarces
force-pushed
the
update-network-nicknames
branch
2 times, most recently
from
638710b to
037e364
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
bergarces
force-pushed
the
update-network-nicknames
branch
from
037e364 to
84f9060
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Popular Network nicknames are incorrect and they are currently being overwritten in both clients during onboarding.
Here we can see how both clients override the names:
https://github.com/MetaMask/metamask-mobile/blob/main/app/core/Engine/controllers/network-controller-init.ts#L55
https://github.com/MetaMask/metamask-extension/blob/main/app/scripts/controller-init/network-controller-init.ts#L83
This PR will make that code redundant and better reflect the initial state.
Here are the draft PRs for both clients. Once this is merged and released the changes will be merged.
MetaMask/metamask-mobile#22137
MetaMask/metamask-extension#37518
References
Related to MetaMask/metamask-extension#37478
Checklist
Note
Medium Risk
Low-complexity string changes, but they affect default network configuration names and error messages, which can break snapshot tests or any consumer relying on exact network display names.
Overview
Updates
NetworkNicknamevalues for several built-in networks (e.g., Mainnet →Ethereum, Base →Base, BSC →BNB Chain, Optimism →OP, Arbitrum One →Arbitrum, Polygon/Sei droppingMainnet).Updates
NetworkControllertest snapshots and expected error strings to match the new default network names, and records the change in@metamask/controller-utilschangelog.Reviewed by Cursor Bugbot for commit 83fee83. Bugbot is set up for automated code reviews on this repo. Configure here.