#VFB-226 - Query flow refactoring and connect top-right corner button to the queries#200
#VFB-226 - Query flow refactoring and connect top-right corner button to the queries#200ddelpiano merged 6 commits intodevelopmentfrom
Conversation
jrmartin
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9f9a60f4b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9f9a60f4b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…prove response formatting
jrmartin
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a0ac86cbd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@jrmartin the tests are failing https://github.com/MetaCell/virtual-fly-brain/actions/runs/21014810759/job/60417639375?pr=200 , could you please fix these before I start reviewing it please? thanks |
…ect on failure, preventing test and client errors when invalid or missing query types are requested. This is needed because stricter query_type validation was introduced in this PR, which can now trigger exceptions that must be handled consistently.
…ES_FAILURE to maintain consistent loading state management
|
@ddelpiano Fixed now |
2 participants
This pull request introduces several improvements to how queries are managed and displayed in the Virtual Fly Brain application. The main focus is on better validation and error handling in the backend, optimizing query data fetching and caching in the frontend, and enhancing the user interface to make query access more intuitive and responsive.
Backend improvements:
query_typeparameter in therun_queryfunction inqueries.py, ensuring that it is provided and valid; an informative error is raised if not.run_query, raising a clear error message instead of returning a result.Frontend data handling and caching:
get_queriesinquery.jsto return only the necessaryqueriesarray andname, minimizing the response payload.getQueriesaction inqueries.jsto check for cached instance data before making network calls, reducing unnecessary requests and improving performance.QueriesReducerto store queries as objects keyed by query name, ensuring efficient updates and lookups.User interface enhancements:
Headercomponent to display a "Queries" button only when relevant queries are available for the focused instance, and to handle loading queries on demand when the button is clicked. [1] [2] [3]