Conversation
Erica Neininger (ericaneininger)
left a comment
There was a problem hiding this comment.
This looks generally fine.
Can you please copy the trac.log file from your rose-stem run - the PR template need updating to request this new feature!
Just an observation - The new output files do not follow the CMIP agreed filenaming convention. The only special character permitted in the "custom" facet is a hyphen, and here we have a period: plot.CF-AIS and plot.CF-GRiS .
Since the rest of the filenames comply with the convention, are we breaking it deliberately, or because we were not aware it was there?
Just for ease of finding them in the changes here... These custom facets are defined in archive_verify/filenames.py and in unicicles/unicicles.py. Thery are then requested in the rose-stem postproc app.
|
Hi Erica, thanks for getting to this so quickly. A good point about the Thanks, Marc ps. I've added the trac.log to the PR summary, as requested. |
Re-running rose-stemFollowing Erica's review and e-mails with Robin Smith (main contributor to the UniCiCles code), I've changed the branch so that I've re-run rose-stem and the new trac.log is Test Suite Results - moci - test_ukesm2_dev2/run1Suite Information
Task Information✅ succeeded tasks - 116 |
|
At the bottom of https://code.metoffice.gov.uk/trac/UKESM/wiki/ticket/1036/extra_plot_files I've created a job to test the new branch, https://code.metoffice.gov.uk/trac/roses-u/log/d/y/3/4/2, and this can be seen to archive the |
PR Summary
Code Reviewer: Erica Neininger (@ericaneininger)
As summarised at the top of issue #31, our prototype UKESM2 model, UKESM2_proto, uses NEMO4.2, whereas UKESM1.3 uses NEMO3.6. At NEMO3.6 the bathymentry file was an input file, but at NEMO4.2 the bathymetry files needs to be generated from a domain file. Consequently for UKESM2_proto, compared to UKESM1.3,
In this ticket I add the domain file and change the rose-stem setup from the UKESM1.3 setup to the UKESM2_proto setup.
Also, includes a fix in expected_content.py for running static ice (which has no restart dumps) for either UKESM1.3 or UKESM2_proto on the final cycle.
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
readability of the code
*1 No additional comments in this change except for the additional unit test, which was written by Erica Pearce, but change is only adding additional arguments to code which is already commented.
Testing
acceptable (eg. kgo changes)
tests, unit tests, etc.)
*2 There's no failures, see output in issue UKESM2 postproc developments #31
*3 I found an error in the code, which this change fixes, and Erica has added a unit test into this change which protects this fix.
I've also run a UKESM2_proto for several years, which archive_integrity running every year, to comfirm that the additional files are being archived and are expected by archive_integrity.
Security Considerations
*4 Not applicable to this change
Performance Impact
performance measurements have been conducted
*5 This adds additional code to both Postproc and rose-stem, but increases should not be significant.
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
*6 No AI used here
Documentation
confirmed that it builds correctly
*7 No additional documentation.
Test Suite Results - moci - test_ukesm2_dev/run1
Suite Information
Task Information
✅ succeeded tasks - 116
Code Review