Remove alg scripts which stop OMP being added to alg#416
Open
Benjamin Went (MetBenjaminWent) wants to merge 1 commit intoMetOffice:mainfrom
Open
Remove alg scripts which stop OMP being added to alg#416Benjamin Went (MetBenjaminWent) wants to merge 1 commit intoMetOffice:mainfrom
Benjamin Went (MetBenjaminWent) wants to merge 1 commit intoMetOffice:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
It seems that we are disabling the OMP in the implicit alg mod. I've removed this, and checked the source to see if the OMP gets added incorrectly around the calls down into the domain imp and imp2 kernels, and they are fine.
Doing this, it enables the OMP around the call into the imp_du kernel which is column wise, and improves bl implcits overall performance, as well as the kernels.
I've not identified in the files history as to why this override was created. The all group, and OMP groups perform fine with this change.
Sci/Tech Reviewer: Hacka Fett (@christophermaynard)
Code Reviewer:
-->
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - remove_imp_alg_script/run1
Suite Information
Task Information
✅ succeeded tasks - 1510
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review