Fix incorrect missing authentication dialog trigger#3703
Merged
tomasMizera merged 3 commits intomasterfrom Feb 3, 2025
Merged
Conversation
VitorVieiraZ
changed the title
VitorVieiraZ
force-pushed
the
fix/missingAuthDialog
branch
from
53771ec to
8b0e92e
Compare
VitorVieiraZ
changed the title
Pull Request Test Coverage Report for Build 13032992744Details
💛 - Coveralls |
VitorVieiraZ
force-pushed
the
fix/missingAuthDialog
branch
from
8b0e92e to
7f5425a
Compare
tomasMizera
approved these changes
Jan 30, 2025
Collaborator
tomasMizera
left a comment
tomasMizera
left a comment
There was a problem hiding this comment.
Looks good, let's test that :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
reloadProjectRole, we check if user is logged with new methodisLoggedInbefore proceeding, preventingmissingAuthorizationErrorandMMMissingAuthDialogfrom popping up.