Skip to content

DNM Enable cast elimination by default#35296

Draft
ggevay wants to merge 1 commit intoMaterializeInc:mainfrom
ggevay:cast-elim-exp
Draft

DNM Enable cast elimination by default#35296
ggevay wants to merge 1 commit intoMaterializeInc:mainfrom
ggevay:cast-elim-exp

Conversation

@ggevay
Copy link
Contributor

@ggevay ggevay commented Mar 2, 2026

This is just to run CI with enable_cast_elimination turned on by default. This is to have more testing coverage after #35084

(The first run is expected to hit slt plan changes. I'll do an auto-rewrite for these, and run again.)

Edit: Hmm, even the first run is already green. How can that be? Maybe the relevant slt tests already had cast elim enabled? We need to check this!

cc @mgree

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

@ggevay ggevay added the A-optimization Area: query optimization and transformation label Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-optimization Area: query optimization and transformation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant