compute: flatten OffsetOptimized to eliminate enum dispatch on hot index path#35293
Draft
def- wants to merge 2 commits intoMaterializeInc:mainfrom
Draft
compute: flatten OffsetOptimized to eliminate enum dispatch on hot index path#35293def- wants to merge 2 commits intoMaterializeInc:mainfrom
def- wants to merge 2 commits intoMaterializeInc:mainfrom
Conversation
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
…dex path Replace the OffsetStride 4-variant enum with three flat fields (stride, steps, reps), turning the hot index() call from two-level match dispatch into a single branch + multiply. Targets ~190G flat CPU in clusterd production profiles (OffsetOptimized::index). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Wrap `offset[i] = stride * i` in backticks to prevent rustdoc from interpreting `[i]` as an intra-doc link. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the OffsetStride 4-variant enum with three flat fields (stride, steps, reps), turning the hot index() call from two-level match dispatch into a single branch + multiply.