(iOS) Fix empty failure tag on JUnit XML report when unknown class#1000
Merged
Malinskiy merged 2 commits intoMarathonLabs:developfrom Apr 29, 2025
Merged
Conversation
Member
|
|
Malinskiy
reviewed
Apr 29, 2025
| } | ||
| data class TestData(val caseName: String, val targetName: String) | ||
|
|
||
| class TestDataProvider : ArgumentsProvider { |
Member
There was a problem hiding this comment.
Appreaciate the time to redo this properly
Malinskiy
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal to fix the issue reported here.
When the xcode execution log prints a test failure with an unknown class, the parser does not detect the error trace with the current regex expression, expecting a proper class path (
/path/to/class):which results into the following failure tag:
... <testcase name="testAccessibility" time="13.387" classname="TestTarget.Tests"> <failure></failure> </testcase> ...For now I do not understand why the log says "unknown" class. However, this change would provide some information on the JUnit XML report about the stacktrace, as a first step to tackle the issue.
Note 1: When multiline stacktrace the parser only captures the first line.
Note 2: as an additional change the related test could be parameterized to simplify the addition of new tests / maintenance of the test.