-
Notifications
You must be signed in to change notification settings - Fork 182
Allow for a registry mirror #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for using a registry mirror for Docker images by introducing a new REGISTRY_MIRROR_URL environment variable. This allows users to prepend a mirror URL to image names without modifying the docker-compose.yml file or managing override files.
Changes:
- Added
REGISTRY_MIRROR_URLenvironment variable documentation in template.env - Updated image references for all ghcr.io services (mail, misp-core, misp-modules, misp-guard) to use the optional registry mirror prefix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| template.env | Adds documentation for the new REGISTRY_MIRROR_URL optional environment variable |
| docker-compose.yml | Updates four image references to support the registry mirror prefix using variable substitution with empty string default |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
|
LGTM but should we extend this to all images? |
ostefano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same trick should work for DockerHub images.
|
@ostefano sure, included it for the dockerhub urls too |
docker supports
registry-mirroronly for Dockerhub images and not for other domains / registries. If you use a package mirror for other registries, you have to change the image name fromghcr.io/xxxxtoregistry-mirror/ghcr.io/xxxx. To avoid having to change the original docker-compose.yml or override it with a.override.ymlfile and keep the versions in sync, this change adds aREGISTRY_MIRROR_URLenv variable to specify an optional registry mirror. If not defined it defaults to an empty string resulting in the original image name.Example:
Without
REGISTRY_MIRROR_URL:With
REGISTRY_MIRROR_URL=internal.mirror.com/: