feat: Add adb rule for Lenovo Legion Tab Y700#360
Conversation
2df3ece to
b38bb1c
Compare
|
Hi @Ylarod, looking at your code here, I believe it would be advantageous to also add another PR with libmtp into file src/music-player.h. You can maybe use this as a template for reference: libmtp/libmtp#294 |
|
Thank you for your extra effort in sending libmtp a PR, very much appreciated. ...and the extra codes you included here will be of benefit for distros running libmtp<=1.1.23 |
|
Overall, I think this is a pretty detailed pull request and if you want to merge, go ahead. basically, the code reduces down to one comment, so the script parse searches for EOL, and finished comment, then goes to the actual instructions (this is about as quick as a parser can go, or hope it will go). ;-p The qualcom section needs some R&D work as it's got duplicates like 9011, but for now, @Ylarod has this part well documented, and that's best for now leaving it as-is in the qualcom portion. I'm okay with the code as-is, it is detailed and covers plenty, but I'm guessing it would be preferred in the format I mentioned above (since @M0Rf30 asked for a review, so yes, if you can make that extra change, please do). @Ylarod - if you want to go the extra effort, run 'lsusb -v' as you switch between modes, sometimes you'll see extra codes that can be added, you can see these lines as examples (where cdc and adbcdc were hiding with mtp and adbmtp): |
| # Xiaomi A1 (90bb=midi,adb) | ||
| ATTR{idProduct}=="90bb", GOTO="adbmidi" | ||
| ATTR{idProduct}=="90dc", GOTO="adb" | ||
| # Lenovo Legion Tab Y700 / FP3 USB tethering mode (ADB disabled) |
There was a problem hiding this comment.
leave this section pretty much as-is, this qualcom section needs some R&D and compression (someday), so all the info you have here is great
| ATTR{idVendor}!="17ef", GOTO="not_Lenovo" | ||
| # Lenovo Tab K10 | ||
| ATTR{idProduct}=="201c", GOTO="adb" | ||
| # Lenovo Legion Tab Y700 ADB / non-data-transfer mode |
There was a problem hiding this comment.
Seems okay, got plenty of codes covered here (especially the main ones). Can leave this as-is, or opt for some scripting compression mentioned in comments.
No description provided.