-
Notifications
You must be signed in to change notification settings - Fork 81
feat: use a caching allocator for GPUArrays workflows #1549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @avik-pal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant performance improvement for GPU-accelerated training workflows by integrating a caching allocator from the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a caching allocator for GPUArrays workflows, aiming to improve performance by reducing memory allocations on the GPU. This is implemented by adding an allocator_cache field to TrainState and refactoring the core training functions to use a dispatch-based system. A new extension, LuxGPUArraysExt, provides the specific caching logic for GPUArrays.AllocCache.
The overall design is solid and uses a clean, non-invasive approach to extend the functionality. The refactoring in training.jl is well-executed.
I have a couple of comments on the new extension file, ext/LuxGPUArraysExt.jl. One is a critical fix for an UndefVarError due to a missing import, and the other is a minor suggestion to improve code cleanliness.
353e9e5 to
bfd75a7
Compare
bfd75a7 to
f99bab9
Compare
Benchmark Results (Julia v1.11)Time benchmarks
Memory benchmarks
|
1d06902 to
6ef2ad5
Compare
fixes #1527