Merged
Conversation
* Add Clang 14 build * Remove no longer supported windows-2016 * Add MSVC 2022 build * Fix variable expansion
…s a header-only library
Specify ARCH_INDEPENDENT when creating package version file as this i…
A non-saturated expectation matching with a sequence object that has run to its end must be reported as an out of sequence match.
Support piecemeal catch2 headers
trailing_return_mock
Demonstrate bug rollbear#343 - since MSVC offers individual options to control /std:c++20, /Zc:__cplusplus, and /Zc:preprocessor, it's possible to have a combination where the compiler is in C++20 mode (and says so), but the traditional preprocessor (which not support __VA_OPT__) is in use. This configuration is commonly trigged by Qt6, which requires c++17, suggests c++20, sets /Zc:__cpluspls (so it can #ifdef based on compiler), but doesn't care about the preprocessor. MSVC still doesn't enable the new /Zc:preprocessor by default, even with /std:c++20 or /permissive-.
Only the new conformant MSVC preprocessor (_MSVC_TRADITIONAL==0) ever has __VA_OPT__. This became avaialble with Visual Studio 16.6, but only if running in /std:c++20 or /std:c++latest mode (i.e. _MSVC_LANG > c++17). - https://devblogs.microsoft.com/cppblog/announcing-full-support-for-a-c-c-conformant-preprocessor-in-msvc/ Starting with Visual Studio 17.10, it is now enabled regardless of /std This was changed to better match the behavaior of GCC and clang, which also loosened up their checks: - https://developercommunity.visualstudio.com/t/Zc:preprocessor-__VA_OPT__-is-not-enabl/10205604 - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98859 (GCC 13 and up allow __VA_OPT__ in -std=c2x as well as -std=c++20) - https://reviews.llvm.org/D91913 (clang 12 and up allow __VA_OPT__ regardless of c/c++ standard) The MSVC traditional preprocessor (_MSVC_TRADITIONAL defined and nonzero) never supports __VA_OPT__, regardless of MSVC or c++ standard version.
Fix feature detection of __VA_OPT__ for MSVC
Not needed, it's already included in the environment
muliby-lb
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.