Skip to content

Improve performance of addLayers by preallocating array #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pmarrapese wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Improve performance of addLayers by preallocating array #988

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ccab47d
improved performance of addLayers by preallocating array
pmarrapese Apr 6, 2020
72a53a6
Merge branch 'Leaflet:master' into addLayers-perf-fix
pmarrapese Oct 26, 2022
f7a510e
addLayers performance: use concat instead of push
pmarrapese Oct 26, 2022
1641cf5
Check for finite min and max zoom properties
Apr 27, 2020
ec8261d
Adding markers aria-label for accessibility
tmiaa Jan 9, 2022
f43d89c
Merge branch 'Leaflet:master' into addLayers-perf-fix
pmarrapese Jul 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/MarkerClusterGroup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,8 @@ export var MarkerClusterGroup = L.MarkerClusterGroup = L.FeatureGroup.extend({

process();
} else {
var needsClustering = this._needsClustering;
var needsClustering = new Array(l - offset); // improve performance by preallocating the maximum size of our array
var tail = 0;

for (; offset < l; offset++) {
m = layersArray[offset];
Expand All @@ -318,8 +319,11 @@ export var MarkerClusterGroup = L.MarkerClusterGroup = L.FeatureGroup.extend({
continue;
}

needsClustering.push(m);
needsClustering[tail++] = m;
}

needsClustering = needsClustering.slice(0, tail); // truncate empty elements
this._needsClustering = this._needsClustering.concat(needsClustering);
}
return this;
},
Expand Down