Skip to content

Wavs app review#1132

Merged
JakeHartnell merged 2 commits intowavs-appfrom
wavs-app-review
Mar 5, 2026
Merged

Wavs app review#1132
JakeHartnell merged 2 commits intowavs-appfrom
wavs-app-review

Conversation

@ismellike
Copy link
Collaborator

@ismellike ismellike commented Mar 5, 2026

ref #1122

Things to note:

  • pause state should be persisted in the service registry file
  • pausing a service that's not found should error
  • rest of changes were small code improvements

ismellike and others added 2 commits March 4, 2026 18:22
…bmissionConfirmed

- Persist pause/resume state in service registry so it survives node restarts
- Add is_active check in dispatcher loop to skip paused services early
- Switch fs handler from blocking std::fs to async tokio::fs
- Refactor SubmissionConfirmed to carry only needed fields instead of cloning full Submission
- Use atomic writes (tempfile + persist) for dev service persistence
- Fix unused variable warning in TauriHandle Mock arm

Co-Authored-By: Claude Opus 4.6 <[email protected]>
- set_status now returns NotFound error for missing service managers
- Test round-trip: pause -> reload -> verify persisted
- Test legacy registry files without status field default to Active
@ismellike ismellike requested review from dakom and ueco-jb as code owners March 5, 2026 16:52
@JakeHartnell
Copy link
Contributor

Very nice! Thanks for these fixes. :)

@JakeHartnell JakeHartnell merged commit 8e3ab30 into wavs-app Mar 5, 2026
1 check passed
@JakeHartnell JakeHartnell deleted the wavs-app-review branch March 5, 2026 17:11
@ismellike ismellike mentioned this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants