Show a disabled setting->description field on edit#93
Open
ikkebra wants to merge 1 commit intoLaravel-Backpack:mainfrom
Open
Show a disabled setting->description field on edit#93ikkebra wants to merge 1 commit intoLaravel-Backpack:mainfrom
ikkebra wants to merge 1 commit intoLaravel-Backpack:mainfrom
Conversation
The setting->description describes what the setting does, but we are never able to see the full description in the admin panel. We are able to see a truncated description in the index view of the settings i.e. "Email addresses separated by comma, to b[...]" but when we edit that setting, we don't see the description at all. The description provides useful information on what the setting does and should be shown on the edit page as a disabled field, similar to the setting->name. I made it a textarea instead of text in case the description is overly long.
|
BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly. Please keep in mind that:
Thank you! -- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setting->description describes what the setting does, but we are never able to see the full description in the admin panel. We are able to see a truncated description in the index view of the settings i.e. "Email addresses separated by comma, to b[...]" but when we edit that setting, we don't see the description at all. The description provides useful information on what the setting does and should be shown on the edit page as a disabled field, similar to the setting->name. I made it a textarea instead of text in case the description is overly long.