Skip to content

Complete FreeBSD support, also fix 'tun' device for it.#2

Open
mmokhi wants to merge 4 commits intoLaKabane:masterfrom
mmokhi:master
Open

Complete FreeBSD support, also fix 'tun' device for it.#2
mmokhi wants to merge 4 commits intoLaKabane:masterfrom
mmokhi:master

Conversation

@mmokhi
Copy link
Contributor

@mmokhi mmokhi commented Oct 31, 2016

FreeBSD's tun interface needs two IP addresses.
According documents (like This and also official docs) SIOCSIFADDR command is deprecated.
So i rewrote some parts of it in a backward compatible manner.
According the final test results you can now update the README and add FreeBSD as completely supported platform.

@tribouille
Copy link
Member

tribouille commented Nov 1, 2016

I don't have time right now to check deeply the patch...
but, in any way, we won't accept it like that as you change the license terms.
Please, keep the ISC license: https://en.wikipedia.org/wiki/ISC_license

@mmokhi
Copy link
Contributor Author

mmokhi commented Nov 1, 2016

It's (Free)BSD license.
Actually nothing will be changed by using it, It has nothing (by law point of view) conflicting with MIT/ISC.
BTW, if you have serious problems with BSD license, I can re-release it with your license conditions 😄

@mmokhi
Copy link
Contributor Author

mmokhi commented Nov 1, 2016

I just used (Free)BSD license, cause i did it for my purposes for FreeBSD community 😉

@tleguern
Copy link
Member

tleguern commented Nov 1, 2016

Thanks for your interest in our project ! I will look at your patch next week if Tribou don't beat me to it.

On October 31, 2016 6:18:02 PM CET, m0khi notifications@github.com wrote:

FreeBSD's tun interface needs two IP addresses.
According documents (like
This and also official docs)
SIOCSIFADDR command is deprecated.
So i rewrote some parts of it in a backward compatible manner.
According the final test results you can now update the README and add
FreeBSD as completely supported platform.
You can view, comment on, or merge this pull request online at:

#2

-- Commit Summary --

-- File Changes --

M regress/test14.c (2)
M regress/test18.c (2)
M regress/test33.sh (8)
M regress/test34.sh (4)
M tuntap-unix-freebsd.c (84)
M tuntap-unix.c (11)
M tuntap.c (95)
M tuntap.h (26)

-- Patch Links --

https://github.com/LaKabane/libtuntap/pull/2.patch
https://github.com/LaKabane/libtuntap/pull/2.diff

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#2

Sent from my Android device with K-9 Mail. Please excuse my brevity.

@mmokhi
Copy link
Contributor Author

mmokhi commented Nov 1, 2016

Thanks 😁
It's my pleasure if i can help it 😉 👍

So, do you still see problems with (Free)BSD license ?

@mmokhi
Copy link
Contributor Author

mmokhi commented Nov 12, 2016

Guys, Have you had any chances to check/review parts of this?

@tribouille
Copy link
Member

Hi,
nope, sorry.
I'll try before the end of the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants