Prevent key modifiers in MainWindow from getting stuck#8282
Open
yohannd1 wants to merge 1 commit intoLMMS:masterfrom
Open
Prevent key modifiers in MainWindow from getting stuck#8282yohannd1 wants to merge 1 commit intoLMMS:masterfrom
MainWindow from getting stuck#8282yohannd1 wants to merge 1 commit intoLMMS:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some extra code to
MainWindow::eventFilter, and adds such event filter to itself, in order to detect events which may suppress key-release events of modifiers, which in my experience have been the ones such of typeQEvent::WindowDeactivate. It also removes theMainWindow::focusOutEventoverload, which indeed didn't seem to be called. In case that event ever gets received, though, the event filter should be handling it properly.Previously, the bug could be replicated by holding shift in LMMS, then changing to another window, then releasing shift. After going back to LMMS (without pressing shift again) and using a knob, it would change values slowly (as if shift was still being pressed).
I've also removed the
[[deprecated]]notice fromMainWindow::isShiftPressed, though I'm not sure if this was the sole reason for its deprecation.